[C++] Add detail logs for schema related messages #9544
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If broker failed to parse the schema, the logs of C++/Python client is poor because when C++ client handles the
Error
response, it doesn't print themessage
field that is filled by broker. On the other hand, if theInvalidSchemaDataException
is thrown byStructSchemaDataValidator#throwInvalidSchemaDataException
, the detail error message will be written to the exception's cause. The String thatgetMessage()
returns is not enoughModifications
tryAddSchema
failed, add the exception cause's message to the error message that's sent to client.Error
response'smessage
field to logs.Verifying this change
This change is a trivial rework / code cleanup without any test coverage. Take #9483 (which is to be fixed) as the example, before this PR, the client side's log is like
After this PR, the client side's log will be