[Functions] Call the corresponding restart according to the componenttype. #9502 #9519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update new
Synchronization code
jiazhai
requested review from
srkukarni,
rdhabalia,
315157973,
codelipenghui and
hangc0276
jiazhai
approved these changes
Feb 7, 2021
|
/pulsarbot run-failure-checks |
freeznet
requested changes
Feb 7, 2021
...unctions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManager.java
Outdated
Show resolved
Hide resolved
...unctions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManager.java
Show resolved
Hide resolved
|
@xche thanks for your help on this issue, i have left some comments, PTAL, thanks. |
nlu90
approved these changes
Feb 8, 2021
| this.functionAdmin.functions().restartFunction(tenant, namespace, functionName, | ||
| assignment.getInstance().getInstanceId()); | ||
|
|
||
| ComponentType componentType = assignment.getInstance().getFunctionMetaData().getFunctionDetails().getComponentType(); |
There was a problem hiding this comment.
the code here and on line 422 - 429 are highly similar.
Could you please abstract a method and then reuse it for these two places.
freeznet
approved these changes
Feb 9, 2021
eolivelli
requested changes
Feb 9, 2021
sijie
approved these changes
Feb 9, 2021
|
/pulsarbot run-failure-checks |
315157973
approved these changes
Feb 9, 2021
|
/pulsarbot run-failure-checks |
codelipenghui
pushed a commit
that referenced
this pull request
Feb 18, 2021
…type. #9502 (#9519) Fixes #9502 Add judgment on component type，Call the corresponding restart according to the componenttype ### Motivation Restart all instances of a Pulsar Source failed. When I call the "https://pulsar.apache.org/admin/v3/sources/{tenant}/{namespace}/{sourceName}/restart" See error "Failed to perform http post request: javax.ws.rs.InternalServerErrorException: HTTP 500 Internal Server Error Function xxxx doesn't exist". The reason for the problem is that the corresponding functionadmin is not found according to the componenttype, which leads to the restart of sink or source using the functionadmin of function (cherry picked from commit 1f1b96d)
This was referenced Feb 22, 2021
sijie
pushed a commit
that referenced
this pull request
Mar 13, 2021
### Motivation This PR is related to #9502 and [PR #9519](#9519). In [PR #9519 ](#9519), another contributer has fixed the problem described in #9502, but there are still some areas that can be optimized. ### Modifications - Abstract a method and then reuse some code. - Adding a unit test for the `restartFunctionInstances` method
fmiguelez
pushed a commit
to fmiguelez/pulsar
that referenced
this pull request
Mar 16, 2021
…pache#9671) ### Motivation This PR is related to apache#9502 and [PR apache#9519](apache#9519). In [PR apache#9519 ](apache#9519), another contributer has fixed the problem described in apache#9502, but there are still some areas that can be optimized. ### Modifications - Abstract a method and then reuse some code. - Adding a unit test for the `restartFunctionInstances` method
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Oct 26, 2021
…pache#9671) This PR is related to apache#9502 and [PR apache#9519](apache#9519). In [PR apache#9519 ](apache#9519), another contributer has fixed the problem described in apache#9502, but there are still some areas that can be optimized. - Abstract a method and then reuse some code. - Adding a unit test for the `restartFunctionInstances` method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9502
Add judgment on component type，Call the corresponding restart according to the componenttype
Motivation
Restart all instances of a Pulsar Source failed.
When I call the "https://pulsar.apache.org/admin/v3/sources/{tenant}/{namespace}/{sourceName}/restart"
See error "Failed to perform http post request: javax.ws.rs.InternalServerErrorException: HTTP 500 Internal Server Error
Function xxxx doesn't exist".
The reason for the problem is that the corresponding functionadmin is not found according to the componenttype, which leads to the restart of sink or source using the functionadmin of function
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation