Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Disable looking up snapshot versions in public repositories #9336

Merged
merged 2 commits into from
Feb 14, 2021

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Jan 27, 2021

Motivation

  • there isn't a need to lookup snapshots in public repositories
  • currently the build will attempt to lookup the snapshot versions of Pulsar modules from public repositories, for example:
Downloading from confluent: http://packages.confluent.io/maven/org/apache/pulsar/pulsar-client-original/2.8.0-SNAPSHOT/maven-metadata.xml
Downloading from central: https://repo1.maven.org/maven2/org/apache/pulsar/pulsar-client-original/2.8.0-SNAPSHOT/maven-metadata.xml

Modifications

Disable snapshots for all maven repositories in pom.xml.

- there isn't a need to lookup snapshots in public repositories
- this improves the Pulsar maven build since currently the build will attempt to lookup the snapshot versions of Pulsar modules from public repositories, for example:
Downloading from confluent: http://packages.confluent.io/maven/org/apache/pulsar/pulsar-client-original/2.8.0-SNAPSHOT/maven-metadata.xml
Downloading from central: https://repo1.maven.org/maven2/org/apache/pulsar/pulsar-client-original/2.8.0-SNAPSHOT/maven-metadata.xml
...
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@merlimat merlimat added this to the 2.8.0 milestone Jan 27, 2021
@lhotari
Copy link
Member Author

lhotari commented Jan 27, 2021

/pulsarbot run-failure-checks

3 similar comments
@lhotari
Copy link
Member Author

lhotari commented Jan 29, 2021

/pulsarbot run-failure-checks

@lhotari
Copy link
Member Author

lhotari commented Feb 1, 2021

/pulsarbot run-failure-checks

@jiazhai
Copy link
Member

jiazhai commented Feb 1, 2021

/pulsarbot run-failure-checks

@lhotari
Copy link
Member Author

lhotari commented Feb 2, 2021

/pulsarbot run-failure-checks

@lhotari
Copy link
Member Author

lhotari commented Feb 12, 2021

/pulsarbot run-failure-checks

@aahmed-se aahmed-se self-requested a review February 12, 2021 18:45
@lhotari
Copy link
Member Author

lhotari commented Feb 13, 2021

/pulsarbot run-failure-checks

@merlimat merlimat merged commit 71eeccc into apache:master Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants