-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Disable looking up snapshot versions in public repositories #9336
Merged
merlimat
merged 2 commits into
apache:master
from
lhotari:lh-disable-repository-snapshots
Feb 14, 2021
Merged
[Build] Disable looking up snapshot versions in public repositories #9336
merlimat
merged 2 commits into
apache:master
from
lhotari:lh-disable-repository-snapshots
Feb 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- there isn't a need to lookup snapshots in public repositories - this improves the Pulsar maven build since currently the build will attempt to lookup the snapshot versions of Pulsar modules from public repositories, for example: Downloading from confluent: http://packages.confluent.io/maven/org/apache/pulsar/pulsar-client-original/2.8.0-SNAPSHOT/maven-metadata.xml Downloading from central: https://repo1.maven.org/maven2/org/apache/pulsar/pulsar-client-original/2.8.0-SNAPSHOT/maven-metadata.xml ...
eolivelli
approved these changes
Jan 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
merlimat
approved these changes
Jan 27, 2021
sijie
approved these changes
Jan 27, 2021
codelipenghui
approved these changes
Jan 27, 2021
zymap
approved these changes
Jan 27, 2021
/pulsarbot run-failure-checks |
3 similar comments
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Feb 1, 2021
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
aahmed-se
approved these changes
Feb 12, 2021
/pulsarbot run-failure-checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Disable snapshots for all maven repositories in
pom.xml
.