Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 9279: Pulsar Admin: add command to list bookies #9283

Merged
merged 13 commits into from
Feb 10, 2021

Conversation

eolivelli
Copy link
Contributor

Fixes #9279

Motivation

It would be more user friendly to have a "list-bookies" command in pulsar-admin, as described in #9279

Modifications

  • add bookies/all API
  • add list-bookies command
  • add relevant test cases

Verifying this change

This change added tests

Does this pull request potentially affect one of the following parts:

  • The rest endpoints: yes (a new REST API resource)

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? not documented - self explaining when using pulsar-admin help
  • If a feature is not applicable for documentation, explain why? it is explained in pulsar-admin help

@eolivelli
Copy link
Contributor Author

I have resolved all of the conflicts.

@eolivelli
Copy link
Contributor Author

@rdhabalia @Renkai can you please take a look ?

Copy link
Contributor

@rdhabalia rdhabalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eolivelli
Copy link
Contributor Author

/pulsarbot run-failure-checks

@rdhabalia rdhabalia merged commit fcb2bb6 into apache:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pulsar Admin: add command to list bookies
3 participants