[flaky test] Fix unit tests that occasionally fail #9226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiazhai
approved these changes
Jan 17, 2021
eolivelli
requested changes
Jan 17, 2021
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorRateLimiterTest.java
Outdated
Show resolved
Hide resolved
codelipenghui
approved these changes
Jan 18, 2021
|
The following three unit tests will also have a high probability of failing, and another issue should be opened to see why: |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
merlimat
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Apr 6, 2021
* fix unit test * fix unit test * fix unit test
zymap
pushed a commit
that referenced
this pull request
Apr 14, 2021
* fix unit test * fix unit test * fix unit test (cherry picked from commit 63acd20)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some unit tests modify the global conf, but do not restore it, which will affect other unit tests.For example: restricted frequency
TopicDuplicationTest.testTopicPolicyTakeSnapshot: The interval of this unit test has been increased
. If the interval is too short, it cannot be completed within the specified interval when the broker is busy. After the modification, call the test 500 times without any exception.
ConsumedLedgersTrimTest: Did not clean up
Modifications
add resetConfig() or restore config
Verifying this change