Fix incoming message size issue that introduced in #9113 #9182
+73
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
requested review from
merlimat,
sijie,
rdhabalia,
jiazhai and
315157973
|
@BewareMyPower @lhotari Please help review this PR |
|
OK, I'll take a look soon. |
BewareMyPower
requested changes
Jan 12, 2021
pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java
Outdated
Show resolved
Hide resolved
lhotari
reviewed
Jan 12, 2021
| for (int i = 0; i < messages; i++) { | ||
| messageIds.add(producer.newMessage().value(("Message-" + i).getBytes()).sendAsync()); | ||
| } | ||
| FutureUtil.waitForAll(messageIds).get(); |
There was a problem hiding this comment.
nitpick: in general, it's good to use timeouts in tests, for example using .get(3, TimeUnit.SECONDS). However, I guess it's not very likely that sending would fail at this point, so the timeout isn't that relevant in this case.
There was a problem hiding this comment.
I don't think using timeout is a good idea. We should rely on the test framework timeout not the timeouts within the test.
There was a problem hiding this comment.
@sijie yes, I agree that placing timeouts all over could clutter the test code.
Do you happen to know if there's already a default timeout set for each individual test method?
There was a problem hiding this comment.
Yes. The TestNG has global timeout settings.
lhotari
approved these changes
Jan 12, 2021
315157973
reviewed
Jan 12, 2021
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java
Outdated
Show resolved
Hide resolved
|
@BewareMyPower @315157973 I have addressed your comments, please take a look again. |
BewareMyPower
approved these changes
Jan 12, 2021
lhotari
approved these changes
Jan 12, 2021
|
The import of VisibleForTesting has not been deleted, I don’t know if the style check will report an error |
sijie
approved these changes
Jan 12, 2021
codelipenghui
added a commit
that referenced
this pull request
Jan 13, 2021
Fix incoming message size issue that introduced in #9113. We should decrease the incoming message size when taking messages from the queue and increase the incoming message size while adding messages to the queue. With #9113, will always increase the incoming queue size. Add method `increaseIncomingSize` and `decreaseIncomingSize` Add a new test for verifying the incoming message size should be zero while the incoming queue size is zero. (cherry picked from commit 2cee0a8)
codelipenghui
added a commit
that referenced
this pull request
Jan 14, 2021
### Motivation Fix incoming message size issue that introduced in #9113. We should decrease the incoming message size when taking messages from the queue and increase the incoming message size while adding messages to the queue. With #9113, will always increase the incoming queue size. ### Modifications Add method `increaseIncomingSize` and `decreaseIncomingSize` ### Verifying this change Add a new test for verifying the incoming message size should be zero while the incoming queue size is zero. (cherry picked from commit 2cee0a8)
freeznet
pushed a commit
to streamnative/pulsar-archived
that referenced
this pull request
Jan 14, 2021
…e#9182) ### Motivation Fix incoming message size issue that introduced in apache#9113. We should decrease the incoming message size when taking messages from the queue and increase the incoming message size while adding messages to the queue. With apache#9113, will always increase the incoming queue size. ### Modifications Add method `increaseIncomingSize` and `decreaseIncomingSize` ### Verifying this change Add a new test for verifying the incoming message size should be zero while the incoming queue size is zero. (cherry picked from commit 2cee0a8)
merlimat
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Apr 6, 2021
…e#9182) ### Motivation Fix incoming message size issue that introduced in apache#9113. We should decrease the incoming message size when taking messages from the queue and increase the incoming message size while adding messages to the queue. With apache#9113, will always increase the incoming queue size. ### Modifications Add method `increaseIncomingSize` and `decreaseIncomingSize` ### Verifying this change Add a new test for verifying the incoming message size should be zero while the incoming queue size is zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix incoming message size issue that introduced in #9113. We should decrease the incoming message size when taking messages from the queue and increase the incoming message size while adding messages to the queue. With #9113, will always increase the incoming queue size.
Modifications
Add method
increaseIncomingSizeanddecreaseIncomingSizeVerifying this change
Add a new test for verifying the incoming message size should be zero while the incoming queue size is zero.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation