Split pulsar-client-and-admin-shade-test into two parts #8716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 16, 2020 17:10
# Conflicts: # tests/pom.xml # tests/pulsar-client-all-shade-test/pom.xml
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Dec 1, 2020
RobertIndie
pushed a commit
to RobertIndie/pulsar
that referenced
this pull request
Dec 8, 2020
Motivation Add test for apache#8697 and other shade problems. Modifications splitting pulsar-client-and-admin-shade-test into two parts, before the pulsar-admin and pulsar-client shade tests were together, can cause some potential problems. * Add CI test for shade package * fix style * fix license * separate shade package * fix pom.xml * fix codestyle * remove unused import Co-authored-by: WeijieGuo <reswqa@bupt.edu.cn>
codelipenghui
pushed a commit
that referenced
this pull request
Feb 19, 2021
Motivation Add test for #8697 and other shade problems. Modifications splitting pulsar-client-and-admin-shade-test into two parts, before the pulsar-admin and pulsar-client shade tests were together, can cause some potential problems. * Add CI test for shade package * fix style * fix license * separate shade package * fix pom.xml * fix codestyle * remove unused import Co-authored-by: WeijieGuo <reswqa@bupt.edu.cn> (cherry picked from commit 7f62bbc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add test for #8697 and other shade problems.
Modifications
splitting pulsar-client-and-admin-shade-test into two parts, before the pulsar-admin and pulsar-client shade tests were together, can cause some potential problems.