Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix idea warning #8588

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Fix idea warning #8588

merged 1 commit into from
Nov 30, 2020

Conversation

hezhangjian
Copy link
Member

Motivation

When open project in idea, it hints there are something to optimize to make clean code

Modifications

  • Move the param annotation to it's origin class
  • The generic can be omit
  • Unused imports
  • incorrect log params

@hezhangjian
Copy link
Member Author

/pulsarbot run-failure-checks

1 similar comment
@hezhangjian
Copy link
Member Author

/pulsarbot run-failure-checks

sijie
sijie requested changes Nov 18, 2020
View reviewed changes
Copy link
Member

@sijie sijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. But let's hold on merging this until 2.7.0 is released.

@hezhangjian
Copy link
Member Author

/pulsarbot run-failure-checks

@sijie sijie added this to the 2.8.0 milestone Nov 30, 2020
@sijie sijie added the type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use label Nov 30, 2020
@sijie sijie merged commit 77f7965 into apache:master Nov 30, 2020
codelipenghui pushed a commit that referenced this pull request Jan 7, 2021
@codelipenghui
Fix idea warning (#8588)
4c2cded 
### Motivation

When open project in idea, it hints there are something to optimize to make clean code

### Modifications

- Move the param annotation to it's origin class
- The generic can be omit
- Unused imports
- incorrect log params

(cherry picked from commit 77f7965)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

Assignees

@hezhangjian hezhangjian

Labels
cherry-picked/branch-2.7 Archived: 2.7 is end of life release/2.7.1 type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hezhangjian @sijie @codelipenghui