Change bookkeeper main method class #8065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
approved these changes
Sep 15, 2020
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Sep 17, 2020
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Oct 3, 2020
### Motivation * `BookieServer::main()` is legacy method. https://github.com/apache/bookkeeper/blob/release-4.9.2/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java#L310-L315 ``` /** * Legacy Method to run bookie server. */ public static void main(String[] args) { Main.main(args); } ``` ### Modifications * Call `Main::main()` instead of `BookieServer::main()`. https://github.com/apache/bookkeeper/blob/release-4.9.2/bookkeeper-server/src/main/java/org/apache/bookkeeper/server/Main.java#L202-L205
zymap
added a commit
to zymap/pulsar
that referenced
this pull request
Dec 2, 2020
--- Fixes apache#8790 *Motivation* The test HealthCheckTest.testBookKeeperDown always failed. That because of we have a change in the `bin/pulsar bookie`. apache#8065 changed the main class name so the bookie process name change to the `MAIN` not `BookieServer`.
RobertIndie
pushed a commit
to RobertIndie/pulsar
that referenced
this pull request
Dec 8, 2020
--- Fixes apache#8790 *Motivation* The test HealthCheckTest.testBookKeeperDown always failed. That because of we have a change in the `bin/pulsar bookie`. apache#8065 changed the main class name so the bookie process name change to the `MAIN` not `BookieServer`.
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 26, 2021
--- Fixes apache#8790 *Motivation* The test HealthCheckTest.testBookKeeperDown always failed. That because of we have a change in the `bin/pulsar bookie`. apache#8065 changed the main class name so the bookie process name change to the `MAIN` not `BookieServer`. (cherry picked from commit 258d166)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
BookieServer::main()is legacy method.https://github.com/apache/bookkeeper/blob/release-4.9.2/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java#L310-L315
Modifications
Main::main()instead ofBookieServer::main().https://github.com/apache/bookkeeper/blob/release-4.9.2/bookkeeper-server/src/main/java/org/apache/bookkeeper/server/Main.java#L202-L205