Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue 5922] - Cleanup poms to use ${project.groupId} and ${project.version} consistently #7548

Merged
merged 2 commits into from
Jul 16, 2020
Merged

[Issue 5922] - Cleanup poms to use ${project.groupId} and ${project.version} consistently #7548

merged 2 commits into from
Jul 16, 2020

Conversation

vcottagiri
Copy link
Contributor

@vcottagiri vcottagiri commented Jul 15, 2020 •
edited
Loading

Fixes #5922

Motivation

As described in #5922
To make the poms consistent across the codebase

Modifications

  • Replaced org.apache.pulsar to ${project.groupId} where applicable
  • Replaced 2.7.0-SNAPSHOT to ${project.version} where applicable
  • Replaced ${project.parent.version} to ${project.version} where applicable
  • Removed org.apache.pulsar when redundant

Verifying this change

  • Make sure that the change passes the CI checks.
  • This change is a trivial rework / code cleanup without any test coverage.

@vcottagiri vcottagiri changed the title Issue #5922 - Cleanup poms to use ${project.groupId} and ${project.version} consistently [Issue 5922] - Cleanup poms to use ${project.groupId} and ${project.version} consistently Jul 15, 2020
@merlimat merlimat added this to the 2.7.0 milestone Jul 15, 2020
@merlimat merlimat merged commit 4acf775 into apache:master Jul 16, 2020
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
@vcottagiri @huangdx0726
apache#5922 - Update poms to use project.groupId instead of org.apach…
d79201b 
…e.pulsar where applicable (apache#7548)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

Assignees
No one assigned
Labels
area/build
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

On the dependencies in the pom.xml files.
2 participants
@vcottagiri @merlimat