Add limited module set profile to the pom files #7541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aahmed-se
force-pushed
the
core_modules
branch
2 times, most recently
from
6ebf144 to
999cf21
Compare
merlimat
reviewed
Jul 15, 2020
| <profile> | ||
| <id>core-modules</id> | ||
| <modules> | ||
| <module>buildtools</module> |
There was a problem hiding this comment.
Ideally, it would be better to not have to repeat the list of core-modules in both lists. I'm not sure that is possible.
In absence of that, we could just make it visually clear, with the list of core-modules sorted in same way and with spaces (and comments) from the extra modules.
merlimat
approved these changes
Jul 15, 2020
|
@aahmed-se After this, we can also change some of the github jobs to just compile core modules (eg: all the broker test jobs, the C++ build, ..) |
|
@aahmed-se One more thing, these modules should not be in the |
|
As well as |
merlimat
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Jul 21, 2020
gaoran10
added a commit
to gaoran10/pulsar
that referenced
this pull request
Jul 22, 2020
This reverts commit b8cba18.
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since pulsar has grown a large project it's useful to have more limited build profiles in maven to focus on the core modules.