Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: make SubscriptionMode a member of ConsumerConfigurationData #6337

Merged
merged 2 commits into from
Feb 18, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add sub mode config in consumerBuilder
jiazhai committed Feb 17, 2020
commit 6a96226b4e4ee6117563c2e5cf9f636b36ab722d
Original file line number Diff line number Diff line change
@@ -228,6 +228,21 @@ public interface ConsumerBuilder<T> extends Cloneable {
*/
ConsumerBuilder<T> subscriptionType(SubscriptionType subscriptionType);

/**
* Select the subscription mode to be used when subscribing to the topic.
*
* <p>Options are:
* <ul>
* <li>{@link SubscriptionMode#Durable} (Default)</li>
* <li>{@link SubscriptionMode#NonDurable}</li>
* </ul>
*
* @param subscriptionMode
* the subscription mode value
* @return the consumer builder instance
*/
ConsumerBuilder<T> subscriptionMode(SubscriptionMode subscriptionMode);

/**
* Sets a {@link MessageListener} for the consumer
*
Original file line number Diff line number Diff line change
@@ -47,6 +47,7 @@
import org.apache.pulsar.client.api.PulsarClientException.InvalidConfigurationException;
import org.apache.pulsar.client.api.Schema;
import org.apache.pulsar.client.api.SubscriptionInitialPosition;
import org.apache.pulsar.client.api.SubscriptionMode;
import org.apache.pulsar.client.api.SubscriptionType;
import org.apache.pulsar.client.impl.conf.ConfigurationDataUtils;
import org.apache.pulsar.client.impl.conf.ConsumerConfigurationData;
@@ -191,6 +192,13 @@ public ConsumerBuilder<T> subscriptionType(@NonNull SubscriptionType subscriptio
return this;
}

@Override
public ConsumerBuilder<T> subscriptionMode(@NonNull SubscriptionMode subscriptionMode) {
conf.setSubscriptionMode(subscriptionMode);
return this;
}


@Override
public ConsumerBuilder<T> messageListener(@NonNull MessageListener<T> messageListener) {
conf.setMessageListener(messageListener);