Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Schema] [Pulsar Functions] Fix schema def build error with protobuf schema #5569

Merged
merged 1 commit into from
Nov 6, 2019
Merged

[Schema] [Pulsar Functions] Fix schema def build error with protobuf schema #5569

merged 1 commit into from
Nov 6, 2019

Conversation

wolfstudy
Copy link
Member

Signed-off-by: xiaolong.ran ranxiaolong716@gmail.com

Fixes #5566

Motivation

In newSchemaInstance func, the properties param is Collections.emptyMap()

case PROTOBUF:
    return ProtobufSchema.ofGenericClass(clazz, Collections.emptyMap());

but in build of SchemaDefinition, we want put some things to map:

properties.put(ALWAYS_ALLOW_NULL, this.alwaysAllowNull ? "true" : "false");

Modifications

Use HashMap instead of Collections.emptyMap().

@wolfstudy
Fix protobuf schema of java function error
1e45b8a 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy wolfstudy self-assigned this Nov 6, 2019
@wolfstudy wolfstudy added this to the 2.5.0 milestone Nov 6, 2019
@wolfstudy
Copy link
Member Author

@congbobo184 PTAL

congbobo184
congbobo184 approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@congbobo184 congbobo184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sijie
Copy link
Member

sijie commented Nov 6, 2019

run java8 tests

2 similar comments
@wolfstudy
Copy link
Member Author

run java8 tests

@wolfstudy
Copy link
Member Author

run java8 tests

@wolfstudy wolfstudy merged commit 5c771d2 into apache:master Nov 6, 2019
@sijie sijie modified the milestones: 2.5.0, 2.4.2 Nov 6, 2019
@sijie
Copy link
Member

sijie commented Nov 6, 2019

@wolfstudy I changed the milestone to 2.4.2.

wolfstudy added a commit that referenced this pull request Nov 20, 2019
@wolfstudy
Fix protobuf schema of java function error (#5569)
8ff212f 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
(cherry picked from commit 5c771d2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@congbobo184 congbobo184 congbobo184 approved these changes

@srkukarni srkukarni Awaiting requested review from srkukarni

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

@jiazhai jiazhai Awaiting requested review from jiazhai

Assignees

@wolfstudy wolfstudy

Labels
area/function
Projects
None yet
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.

[Java Functions] Use protobuf schema error
3 participants
@wolfstudy @sijie @congbobo184