Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for links to other markdown docs. #5411

Merged
merged 2 commits into from
Oct 24, 2019

Conversation

cckellogg
Copy link
Contributor

This adds a unit test to check that the documentation markdown files are linking to valid markdown files.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@cckellogg cckellogg changed the title [Add test for links to other markdown docs. Add test for links to other markdown docs. Oct 18, 2019
@jerrypeng
Copy link
Contributor

rerun cpp tests
rerun integration tests

2 similar comments
@jerrypeng
Copy link
Contributor

rerun cpp tests
rerun integration tests

@jerrypeng
Copy link
Contributor

rerun cpp tests
rerun integration tests

@jerrypeng
Copy link
Contributor

rerun integration tests
rerun cpp tests

@jerrypeng
Copy link
Contributor

rerun cpp tests

1 similar comment
@jerrypeng
Copy link
Contributor

rerun cpp tests

@sijie
Copy link
Member

sijie commented Oct 24, 2019

run cpp tests

@merlimat merlimat merged commit c5c44a9 into apache:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants