Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 5324][go client] Use Buffered channels to avoid blocking on callback #5336

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

hrsakai
Copy link
Contributor

@hrsakai hrsakai commented Oct 8, 2019

Motivation

  • In order to avoid blocking a thread on callback by using buffered channels.
  • the root cause of [go client] Producer::Close() may get stuck #5324 seems to be in cpp client library(Callbacks must be executed on another thread), but here I modified go client library.
  • In another PR, we will consider fixing the cpp client library.

Modifications

  • Use buffered channels in methods that call async methods.

@hrsakai hrsakai added this to the 2.5.0 milestone Oct 8, 2019
@hrsakai hrsakai self-assigned this Oct 8, 2019
@hrsakai
Copy link
Contributor Author

hrsakai commented Oct 8, 2019

rerun integration tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants