Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cmake to build _pulsar for osx #5263

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Fix Cmake to build _pulsar for osx #5263

merged 1 commit into from
Oct 7, 2019

Conversation

aahmed-se
Copy link
Contributor

setting CMAKE_FIND_LIBRARY_SUFFIXES breaks osx builds this fixes it.

@aahmed-se aahmed-se requested a review from merlimat September 24, 2019 00:54
@aahmed-se aahmed-se self-assigned this Sep 24, 2019
@aahmed-se
Copy link
Contributor Author

run cpp tests

@aahmed-se
Copy link
Contributor Author

@merlimat can we port this 2.4.2 ?

@aahmed-se
Copy link
Contributor Author

run cpp tests

2 similar comments
@aahmed-se
Copy link
Contributor Author

run cpp tests

@aahmed-se
Copy link
Contributor Author

run cpp tests

@aahmed-se
Copy link
Contributor Author

rerun cpp tests

1 similar comment
@aahmed-se
Copy link
Contributor Author

rerun cpp tests

@aahmed-se
Copy link
Contributor Author

run java8 tests
run integration tests

@aahmed-se
Copy link
Contributor Author

run integration tests

@aahmed-se aahmed-se added this to the 2.4.2 milestone Sep 24, 2019
@aahmed-se
Copy link
Contributor Author

run integration tests

1 similar comment
@aahmed-se
Copy link
Contributor Author

run integration tests

@aahmed-se
Copy link
Contributor Author

run integration tests

9 similar comments
@aahmed-se
Copy link
Contributor Author

run integration tests

@aahmed-se
Copy link
Contributor Author

run integration tests

@aahmed-se
Copy link
Contributor Author

run integration tests

@aahmed-se
Copy link
Contributor Author

run integration tests

@aahmed-se
Copy link
Contributor Author

run integration tests

@aahmed-se
Copy link
Contributor Author

run integration tests

@aahmed-se
Copy link
Contributor Author

run integration tests

@aahmed-se
Copy link
Contributor Author

run integration tests

@aahmed-se
Copy link
Contributor Author

run integration tests

@aahmed-se
Copy link
Contributor Author

run java 8 tests

1 similar comment
@aahmed-se
Copy link
Contributor Author

run java 8 tests

@aahmed-se
Copy link
Contributor Author

run java8 tests

@aahmed-se
Copy link
Contributor Author

run integration tests

@aahmed-se
Copy link
Contributor Author

run java8 tests

3 similar comments
@aahmed-se
Copy link
Contributor Author

run java8 tests

@aahmed-se
Copy link
Contributor Author

run java8 tests

@aahmed-se
Copy link
Contributor Author

run java8 tests

@aahmed-se
Copy link
Contributor Author

run integration tests

@aahmed-se
Copy link
Contributor Author

run java8 tests

1 similar comment
@aahmed-se
Copy link
Contributor Author

run java8 tests

@aahmed-se
Copy link
Contributor Author

run java8 tests
run integration tests

@aahmed-se
Copy link
Contributor Author

run java8 tests

@aahmed-se aahmed-se mentioned this pull request Sep 28, 2019
Closed
@aahmed-se
Copy link
Contributor Author

run java8 tests

@aahmed-se
Copy link
Contributor Author

run integration tests

1 similar comment
@aahmed-se
Copy link
Contributor Author

run integration tests

@aahmed-se aahmed-se force-pushed the cmake1 branch 2 times, most recently from f8217a3 to 409c585 Compare October 2, 2019 18:57
@aahmed-se
Copy link
Contributor Author

run unit tests

@aahmed-se
Copy link
Contributor Author

run java8 tests

@aahmed-se
Copy link
Contributor Author

run integration tests

@aahmed-se
Copy link
Contributor Author

run java8 tests

1 similar comment
@aahmed-se
Copy link
Contributor Author

run java8 tests

@aahmed-se aahmed-se requested review from jerrypeng and sijie October 6, 2019 03:03
@aahmed-se aahmed-se merged commit 21e2b52 into apache:master Oct 7, 2019
@aahmed-se aahmed-se deleted the cmake1 branch October 7, 2019 20:01
wolfstudy pushed a commit that referenced this pull request Nov 20, 2019
@aahmed-se @wolfstudy
Fix Cmake to build _pulsar for osx (#5263)
a4a742d 
(cherry picked from commit 21e2b52)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerrypeng jerrypeng jerrypeng approved these changes

@merlimat merlimat Awaiting requested review from merlimat

@sijie sijie Awaiting requested review from sijie

Assignees

@aahmed-se aahmed-se

Labels
None yet
Projects
None yet
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@aahmed-se @jerrypeng