Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce unnecessary track message calls. #4595

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Reduce unnecessary track message calls. #4595

merged 1 commit into from
Jun 26, 2019

Conversation

codelipenghui
Copy link
Contributor

Motivation

Reduce unnecessary track message calls

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@codelipenghui
Copy link
Contributor Author

@wolfstudy Please help review this PR.

@codelipenghui codelipenghui self-assigned this Jun 25, 2019
@codelipenghui codelipenghui added area/client type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages labels Jun 25, 2019
@codelipenghui codelipenghui added this to the 2.4.1 milestone Jun 25, 2019
merlimat
merlimat approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codelipenghui codelipenghui merged commit 553f0fd into apache:master Jun 26, 2019
jiazhai pushed a commit that referenced this pull request Aug 28, 2019
@codelipenghui @jiazhai
Reduce unnecessary track message calls. (#4595)
c78999f 
(cherry picked from commit 553f0fd)
@codelipenghui codelipenghui deleted the reduce_track_message_calls branch May 19, 2021 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@sijie sijie sijie approved these changes

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@jiazhai jiazhai Awaiting requested review from jiazhai

Assignees

@codelipenghui codelipenghui

Labels
area/client type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@codelipenghui @merlimat @sijie