Disable sticky read by default #4526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Motivation* 2.3.x releases turn on StickyRead by default. But StickyRead causes a lot of ArrayIndexOutOfBoundException. See: apache/bookkeeper#1970 and apache#3715 *Modifications* Disable sticy read by default until the bug is fixed and a new bookkeeper version is released.
jiazhai
approved these changes
Jun 13, 2019
codelipenghui
approved these changes
Jun 13, 2019
sijie
added a commit
to apache/bookkeeper
that referenced
this pull request
Jun 21, 2019
Descriptions of the changes in this PR: Master Issue: #1970 Related Issues: apache/pulsar#3715 apache/pulsar#4526 *Motivation* Fixes #1970 By default bookie uses a random generator to generate a bookie index as the sticky read bookie index. However the random generator will generate negative numbers. Hence it will generate negative bookie indexes in write set and cause ArrayIndexOutOfBoundException when bookkeeper attempts to read entries. *Modifications* Make sure getStickyReadBookieIndex not return negative number. *Verify this change* This problem introduced by a random generator. It is very hard to write a unit test to reproduce this issue. Existing StickyRead tests are good to cover this code change. Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <zhaijia@apache.org>, Yong Zhang <zhangyong1025.zy@gmail.com> This closes #2111 from sijie/fix_sticky_read, closes #1970
sijie
added a commit
to apache/bookkeeper
that referenced
this pull request
Jun 21, 2019
Descriptions of the changes in this PR: Master Issue: #1970 Related Issues: apache/pulsar#3715 apache/pulsar#4526 *Motivation* Fixes #1970 By default bookie uses a random generator to generate a bookie index as the sticky read bookie index. However the random generator will generate negative numbers. Hence it will generate negative bookie indexes in write set and cause ArrayIndexOutOfBoundException when bookkeeper attempts to read entries. *Modifications* Make sure getStickyReadBookieIndex not return negative number. *Verify this change* This problem introduced by a random generator. It is very hard to write a unit test to reproduce this issue. Existing StickyRead tests are good to cover this code change. Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <zhaijia@apache.org>, Yong Zhang <zhangyong1025.zy@gmail.com> This closes #2111 from sijie/fix_sticky_read, closes #1970
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
2.3.x releases turn on StickyRead by default.
But StickyRead causes a lot of ArrayIndexOutOfBoundException.
See: apache/bookkeeper#1970 and #3715
Modifications
Disable sticky read by default until the bug is fixed and a new bookkeeper version is released.