fix submit function via url #3934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
approved these changes
Mar 29, 2019
| @@ -385,8 +385,7 @@ public void testE2EPulsarFunction() throws Exception { | |||
|
|
|||
| } | |||
|
|
|||
| @Test(timeOut = 20000) | |||
| public void testPulsarSinkStats() throws Exception { | |||
| public void testPulsarSinkStats(String jarFilePathUrl) throws Exception { | |||
jiazhai
approved these changes
Mar 29, 2019
|
There seems to be genuine test failure: |
|
@merlimat this just means the prometheus stats did not have the function stats in them. Its a timing issue because I am trying to download the jar from a url. I am working on a fix for this |
srkukarni
approved these changes
Mar 29, 2019
merlimat
pushed a commit
that referenced
this pull request
Apr 1, 2019
* fix submit function via url * cleaning up * add test * make method private * add additional tests * cleaning up * improving tests
|
Merged in 2.3.1 at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Submitting a function in which the function package is a url is broker right now. If a user is submitting a function with a url package, he or she will get the following exception:
The reason is because we don't actually download the function package from the URL and load it
Modifications
Download the JAR from the function package URL.
I am not sure why in the code we only download the first 10 bytes from the URL and then delete the file. Was this just to check if the URL is valid?
Maybe @rdhabalia can chime in since he wrote most of this code originally.
Though not sure we should download the function package/JAR so that we can do some validation. The JAR can be very large.