[flink] Allow to specify a custom Pulsar producer #3894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary in pretty much any non-trivial use-case. The ability to control the settings of the Pulsar producer is paramount to building real-life applications
merlimat
added
the
type/enhancement
sijie
approved these changes
Mar 25, 2019
casidiablo
added a commit
to casidiablo/pulsar
that referenced
this pull request
Apr 1, 2019
This is an improvement over apache#3894. Because of how Flink instantiates functions, instead of passing a custom `PulsarProducer` client we need to pass an object that is serializable. The current implementation will default to always call `createProducer()` because `producer` is `transient`, so it will always be null when Flink creates new instances of the sink.
sijie
pushed a commit
that referenced
this pull request
Apr 2, 2019
This is an improvement over #3894. Because of how Flink instantiates functions, instead of passing a custom `PulsarProducer` client we need to pass an object that is serializable. The current implementation will default to always call `createProducer()` because `producer` is `transient`, so it will always be null when Flink creates new instances of the sink.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It is paramount, in pretty much any non-trivial use-case, to control the settings of the Pulsar producer used by the Flink producer.
Modifications
Allowed users to pass a custom Pulsar producer instance.
Verifying this change
Does this pull request potentially affect one of the following parts: