Add a wrapper around Kafka's ProducerInterceptor to support Kafka's ProducerConfig.INTERCEPTOR_CLASSES_CONFIG. #1090 #3843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roducerConfig.INTERCEPTOR_CLASSES_CONFIG.
sijie
added
component/kafka
type/feature
jiazhai
reviewed
Mar 17, 2019
| /** | ||
| * A wrapper for Kafka's {@link org.apache.kafka.clients.producer.ProducerInterceptor} to make pulsar support | ||
| * Kafka ProducerInterceptor. It holds an instance of {@link org.apache.kafka.clients.producer.ProducerInterceptor} | ||
| * ans it'll delegate all invocation to that instance. |
jiazhai
reviewed
Mar 17, 2019
|
|
||
| interceptors = (List) producerConfig.getConfiguredInstances( | ||
| ProducerConfig.INTERCEPTOR_CLASSES_CONFIG, ProducerInterceptor.class); | ||
| //interceptorsClasses.forEach(interceptorClazz -> interceptors.add(createKafkaProducerInterceptor(interceptorClazz))); |
jiazhai
approved these changes
Mar 17, 2019
|
run integration tests |
1 similar comment
|
run integration tests |
|
run integration tests |
|
run java8 tests |
|
run integration tests |
1 similar comment
|
run integration tests |
|
run integration tests |
1 similar comment
|
run integration tests |
|
run integration tests |
|
run java8 tests |
|
run integration tests |
1 similar comment
|
run integration tests |
|
run java8 tests |
|
@codelipenghui can you review this PR also? since it is related to interceptors. |
sijie
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivatio
Add a wrapper around Kafka's
org.apache.kafka.clients.producer.ProducerInterceptorto support Kafka's ProducerConfig.INTERCEPTOR_CLASSES_CONFIG. #1090The wrapper will try to delegate all call to underlying instance of Kafka's
org.apache.kafka.clients.producer.ProducerInterceptorit holds.When
PulsarKafkaProducerconvert a Kafka'sProducerRecordto Pulsar'sMessage, the schema(fixed to type of Schema<byte[]>), key, value, eventTimestamp and partitionID is set.When doing the delegation, we'll do
Pulsar
Message-> Kafka'sProducerRecord-> invoke underlying Kafka'sorg.apache.kafka.clients.producer.ProducerInterceptor#onSend-> PulsarMessageIt'll try to preserve all the information. Verified through unit test.
For
org.apache.kafka.clients.producer.ProducerInterceptor#onSendAcknowledgementit'll callorg.apache.kafka.clients.producer.ProducerInterceptor#onAcknowledgementonly partitionID, eventTimestamp, key byte lenth, value byte length will be pass in.