remove pulsar-client-schema #3184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
reviewed
Dec 14, 2018
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Worker.java
Outdated
Show resolved
Hide resolved
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Worker.java
Outdated
Show resolved
Hide resolved
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/WorkerImpl.java
Outdated
Show resolved
Hide resolved
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/WorkerImpl.java
Outdated
Show resolved
Hide resolved
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/schema/Field.java
Outdated
Show resolved
Hide resolved
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctionWorker.java
Outdated
Show resolved
Hide resolved
…ve_pulsar-client-schema
jerrypeng
changed the title
|
This PR is ready for review |
srkukarni
approved these changes
Dec 14, 2018
|
rerun integration tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Remove pulsar-client-schema module since its not really needed. Merge the module with pulsar-client-original. Reduce project complexity.
This change will also greatly reduce the size of some of the other packages e.g. datagenerator source NAR package from 35MB -> 7 MB
Please note I create a new module called pulsar-client-api to hold API interfaces/classes for pulsar. This is needed for schema related interfaces/classes since many other modules depend on them and it doesn't make since to pull in pulsar-client-original just for the schema API. After discussing with @merlimat, he agrees and recommends to move all API related interfaces/classes into a separate module, since it make it light weight and flexible for other to depend on as well as it works well with javadoc of which to current setup does not work because of shading. In this PR, I only moved a subset of the schema API Interfaces into the pulsar-client-api module as a start.
This PR is read for review