Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[functions][metrics] Update function metrics #2686

Merged
merged 4 commits into from
Oct 3, 2018

Conversation

sijie
Copy link
Member

@sijie sijie commented Sep 30, 2018

some prometheus agent are picky at the prometheus output format. this change to make metric type is by the metric. The resulting output is showed as below

# TYPE pulsar_function__total_processed__sum gauge
pulsar_function__total_processed__sum{cluster="standalone",namespace="test/test-namespace",name="example",instanceId="0"} 0.0 1538351566227
# TYPE pulsar_function__total_successfully_processed__count gauge
pulsar_function__total_successfully_processed__count{cluster="standalone",namespace="test/test-namespace",name="example",instanceId="0"} 0.0 1538351566227
# TYPE pulsar_function__total_successfully_processed__max gauge
pulsar_function__total_successfully_processed__max{cluster="standalone",namespace="test/test-namespace",name="example",instanceId="0"} 0.0 1538351566227
# TYPE pulsar_function__total_successfully_processed__min gauge
pulsar_function__total_successfully_processed__min{cluster="standalone",namespace="test/test-namespace",name="example",instanceId="0"} 0.0 1538351566227
# TYPE pulsar_function__total_successfully_processed__sum gauge
pulsar_function__total_successfully_processed__sum{cluster="standalone",namespace="test/test-namespace",name="example",instanceId="0"} 0.0 1538351566227
# TYPE pulsar_function__total_system_exceptions__count gauge
pulsar_function__total_system_exceptions__count{cluster="standalone",namespace="test/test-namespace",name="example",instanceId="0"} 0.0 1538351566227
# TYPE pulsar_function__total_system_exceptions__max gauge
pulsar_function__total_system_exceptions__max{cluster="standalone",namespace="test/test-namespace",name="example",instanceId="0"} 0.0 1538351566227
# TYPE pulsar_function__total_system_exceptions__min gauge
pulsar_function__total_system_exceptions__min{cluster="standalone",namespace="test/test-namespace",name="example",instanceId="0"} 0.0 1538351566227
# TYPE pulsar_function__total_system_exceptions__sum gauge
pulsar_function__total_system_exceptions__sum{cluster="standalone",namespace="test/test-namespace",name="example",instanceId="0"} 0.0 1538351566227
# TYPE pulsar_function__total_user_exceptions__count gauge
pulsar_function__total_user_exceptions__count{cluster="standalone",namespace="test/test-namespace",name="example",instanceId="0"} 0.0 1538351566227
# TYPE pulsar_function__total_user_exceptions__max gauge

@sijie sijie added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/function component/stats labels Sep 30, 2018
@sijie sijie added this to the 2.3.0 milestone Sep 30, 2018
@sijie sijie self-assigned this Sep 30, 2018
@sijie
Copy link
Member Author

sijie commented Sep 30, 2018

/cc @cckellogg

@sijie
Copy link
Member Author

sijie commented Oct 2, 2018

@merlimat can you review this change?

@merlimat
Copy link
Contributor

merlimat commented Oct 2, 2018

@sijie Can you rebase/merge with master -- That should have fixed several of the flaky tests

@sijie
Copy link
Member Author

sijie commented Oct 2, 2018

rebased to latest master

@sijie
Copy link
Member Author

sijie commented Oct 3, 2018

retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/function type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants