Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed mentions to incubator-pulsar #2620

Merged
merged 6 commits into from
Sep 25, 2018
Merged

Removed mentions to incubator-pulsar #2620

merged 6 commits into from
Sep 25, 2018

Conversation

merlimat
Copy link
Contributor

Motivation

Removed mentions to incubator-pulsar

@merlimat merlimat added this to the 2.2.0-incubating milestone Sep 20, 2018
@merlimat merlimat self-assigned this Sep 20, 2018
ivankelly
ivankelly approved these changes Sep 20, 2018
View reviewed changes
Copy link
Contributor

@ivankelly ivankelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably we're going to have a week of brokeness :)

@massakam
Copy link
Contributor

It seems that this part should be removed.
https://github.com/apache/incubator-pulsar/blob/152e5a3ed6e9b9c4c2446a9d893ba8c863d9700c/distribution/offloaders/src/assemble/offloaders.xml#L31-L35

@merlimat
Copy link
Contributor Author

Good catch @massakam. Removed the rerefence to DISCLAIMER

@merlimat
Copy link
Contributor Author

run cpp tests
run java8 tests

@merlimat
Copy link
Contributor Author

run cpp tests
run integration tests

@merlimat
Copy link
Contributor Author

run java8 tests

3 similar comments
@merlimat
Copy link
Contributor Author

run java8 tests

@merlimat
Copy link
Contributor Author

run java8 tests

@merlimat
Copy link
Contributor Author

run java8 tests

@merlimat merlimat force-pushed the remove-incubating-tag branch from dba8cf6 to 01b350a Compare September 23, 2018 14:22
@merlimat
Copy link
Contributor Author

retest this please

@merlimat
Copy link
Contributor Author

run java8 tests

1 similar comment
@merlimat
Copy link
Contributor Author

run java8 tests

@sijie
Copy link
Member

sijie commented Sep 23, 2018

run java8 tests

1 similar comment
@sijie
Copy link
Member

sijie commented Sep 24, 2018

run java8 tests

@sijie
Copy link
Member

sijie commented Sep 25, 2018

run java8 tests

@merlimat
Copy link
Contributor Author

run cpp tests

1 similar comment
@merlimat
Copy link
Contributor Author

run cpp tests

@merlimat merlimat merged commit 96c10dc into apache:master Sep 25, 2018
@merlimat merlimat deleted the remove-incubating-tag branch September 25, 2018 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivankelly ivankelly ivankelly approved these changes

@sijie sijie sijie approved these changes

@srkukarni srkukarni srkukarni approved these changes

@nkurihar nkurihar nkurihar approved these changes

@maskit maskit Awaiting requested review from maskit

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@jerrypeng jerrypeng Awaiting requested review from jerrypeng

@jiazhai jiazhai Awaiting requested review from jiazhai

@massakam massakam Awaiting requested review from massakam

Assignees

@merlimat merlimat

Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@merlimat @massakam @sijie @ivankelly @srkukarni @nkurihar