Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][client] diable chunk feature for retry/dead letter producer. #24015

Closed

Conversation

thetumbled
Copy link
Member

@thetumbled thetumbled commented Feb 24, 2025

Motivation

  • The subscription mode of retry topic must be shared/key-shared type, which has been clarified in [fix][client] fix retry topic with exclusive mode. #23859.
  • The chunk feature of Pulsar can't work together with shared/key-shared subscription type:
    This feature is currently only supported for non-shared subscriptions and persistent topics.
    The reason accounting for this i guess is that all chunks belonging to same message must be sent to same consumer so that the consumer can ensemble them into one single giant message.

So we can't send chunked message to retry topics.

Modifications

Diable the chunked message feature for retry topic and dead letter topic.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: thetumbled#70

Copy link
Contributor

@BewareMyPower BewareMyPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chunk feature of Pulsar can't work together with shared/key-shared subscription type:

The document is outdated. See #16202

@thetumbled
Copy link
Member Author

The chunk feature of Pulsar can't work together with shared/key-shared subscription type:

The document is outdated. See #16202

Thanks for clarification, the doc need to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants