Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][test] Fix flaky test MetadataStoreTest.emptyStoreTest #23998

Merged

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Feb 17, 2025

Motivation

  • If concurrentPutTest runs before emptyStoreTest, it will cause emptyStoreTest to fail

Modifications

  • change the key used in concurrentPutTest

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

- If concurrentPutTest runs before emptyStoreTest, it will cause emptyStoreTest to fail
@lhotari lhotari added this to the 4.1.0 milestone Feb 17, 2025
@lhotari lhotari requested a review from heesung-sn February 17, 2025 18:29
@lhotari lhotari self-assigned this Feb 17, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 17, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.26%. Comparing base (bbc6224) to head (6cad7dd).
Report is 921 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23998      +/-   ##
============================================
+ Coverage     73.57%   74.26%   +0.68%     
+ Complexity    32624    31917     -707     
============================================
  Files          1877     1853      -24     
  Lines        139502   143869    +4367     
  Branches      15299    16349    +1050     
============================================
+ Hits         102638   106838    +4200     
+ Misses        28908    28652     -256     
- Partials       7956     8379     +423     
Flag Coverage Δ
inttests 26.72% <ø> (+2.14%) ⬆️
systests 23.20% <ø> (-1.13%) ⬇️
unittests 73.79% <ø> (+0.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1045 files with indirect coverage changes

@lhotari lhotari merged commit bcf8afb into apache:master Feb 18, 2025
54 of 56 checks passed
lhotari added a commit that referenced this pull request Feb 19, 2025
lhotari added a commit that referenced this pull request Feb 19, 2025
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants