[improve][meta] Simplify getting parent path in ZKMetadataStore without using java.io.File #23996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut using java.io.File hack
lhotari
requested review from
merlimat,
Technoboy-,
nodece,
dao-jun and
mattisonchao
nodece
approved these changes
Feb 17, 2025
lhotari
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23996 +/- ##
============================================
+ Coverage 73.57% 74.16% +0.58%
+ Complexity 32624 31893 -731
============================================
Files 1877 1853 -24
Lines 139502 143871 +4369
Branches 15299 16350 +1051
============================================
+ Hits 102638 106698 +4060
+ Misses 28908 28784 -124
- Partials 7956 8389 +433
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 19, 2025
…ut using java.io.File (apache#23996) (cherry picked from commit 4bfdcd8) (cherry picked from commit f5d7309)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 20, 2025
…ut using java.io.File (apache#23996) (cherry picked from commit 4bfdcd8) (cherry picked from commit e623a3c)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 24, 2025
…ut using java.io.File (apache#23996) (cherry picked from commit 4bfdcd8) (cherry picked from commit f5d7309)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In ZKMetadataStore.asyncCreateFullPathOptimistic method, there's a hack using java.io.File to resolve the parent path. This could be simplified.
Modifications
Use String operations to resolve parent path.
Documentation
docdoc-requireddoc-not-neededdoc-complete