[improve][proxy] Make keep-alive interval configurable in Pulsar Proxy #23981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
nodece
approved these changes
Feb 13, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23981 +/- ##
============================================
+ Coverage 73.57% 74.23% +0.66%
+ Complexity 32624 32272 -352
============================================
Files 1877 1853 -24
Lines 139502 143827 +4325
Branches 15299 16337 +1038
============================================
+ Hits 102638 106770 +4132
+ Misses 28908 28664 -244
- Partials 7956 8393 +437
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 19, 2025
apache#23981) (cherry picked from commit eb1391a) (cherry picked from commit ebcbfff)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 20, 2025
apache#23981) (cherry picked from commit eb1391a) (cherry picked from commit 594cad2)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 24, 2025
apache#23981) (cherry picked from commit eb1391a) (cherry picked from commit ebcbfff)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23963
Motivation
See #23963. Pulsar's keep-alive internal is currently hard-coded to 30 seconds in Pulsar Proxy and cannot be configured.
Modifications
proxy.confandProxyConfigurationclass.Documentation
docdoc-requireddoc-not-neededdoc-complete