[fix][ml] Fix memory leaks in ManagedCursorInfo and ManagedLedgerInfo decompression and compression #23960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…compression and compression
lhotari
force-pushed
the
lh-fix-ml-netty-leaks-in-managed-cursor-info
branch
from
289c6ac to
5439c40
Compare
lhotari
requested review from
gaoran10,
Technoboy-,
dlg99,
eolivelli and
nicoloboschi
lhotari
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23960 +/- ##
============================================
+ Coverage 73.57% 74.29% +0.71%
+ Complexity 32624 31926 -698
============================================
Files 1877 1853 -24
Lines 139502 143813 +4311
Branches 15299 16336 +1037
============================================
+ Hits 102638 106840 +4202
+ Misses 28908 28602 -306
- Partials 7956 8371 +415
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
… decompression and compression (apache#23960)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 19, 2025
… decompression and compression (apache#23960) (cherry picked from commit 7f595cd) (cherry picked from commit 77dc34d)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 20, 2025
… decompression and compression (apache#23960) (cherry picked from commit 7f595cd) (cherry picked from commit 6ed9efe)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 24, 2025
… decompression and compression (apache#23960) (cherry picked from commit 7f595cd) (cherry picked from commit 77dc34d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Running
ManagedCursorInfoMetadataTestandManagedLedgerInfoMetadataTestwith Netty leak detector'sparanoidlevel reveal NettyByteBufleaks inManagedCursorInfoandManagedLedgerInfodecompression and compression.ManagedCursorInfo compression was introduced in PIP-146. ManagedLedgerInfo compression was introduced earlier, in PR #11490.
Modifications
Fix the leak by properly releasing buffers.
parseManagedCursorInfoandparseManagedLedgerInfomethods there was a clear leak where the ByteBuf instance wasn't releasedcompressManagedInfomethod, theCompositeByteBufinstance was never released.CompositeByteBufmight copy input buffers into a new buffer and releasing the components separately is not a correct approach. Handling exceptional cases such as decompression failing cannot be handled in the compressManagedInfo method. The compression codec implementation should handle releasing any buffers it has allocated in that case. That's why the original handling didn't even make sense.Documentation
docdoc-requireddoc-not-neededdoc-complete