[improve][broker] Avoid PersistentReplicator.expireMessages logic compute backlog twice #23957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpute backlog twice
dao-jun
added
area/broker
area/ML
category/performance
lhotari
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23957 +/- ##
============================================
+ Coverage 73.57% 74.21% +0.64%
+ Complexity 32624 31888 -736
============================================
Files 1877 1853 -24
Lines 139502 143827 +4325
Branches 15299 16344 +1045
============================================
+ Hits 102638 106741 +4103
+ Misses 28908 28684 -224
- Partials 7956 8402 +446
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hanmz
added a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…pute backlog twice (apache#23957)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 19, 2025
…pute backlog twice (apache#23957) (cherry picked from commit 6db275c) (cherry picked from commit 921b75e)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 20, 2025
…pute backlog twice (apache#23957) (cherry picked from commit 6db275c) (cherry picked from commit 127ae84)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 24, 2025
…pute backlog twice (apache#23957) (cherry picked from commit 6db275c) (cherry picked from commit 921b75e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Function
cursor.getNumberOfEntriesInBacklog(false)maybe called twice inPersistentReplicator.expireMessages.This PR #20416 optimizes similar problems in
PersistentSubscription.expireMessages.Modifications
Save backlog to variable.
Documentation
docdoc-requireddoc-not-neededdoc-complete