Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Do not print error logs for NotFound or Conflict errors when using the Admin API #23928

Merged
merged 3 commits into from
Feb 6, 2025
Merged

[improve][broker] Do not print error logs for NotFound or Conflict errors when using the Admin API #23928

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c83316
[improve][broker] Do not print error logs for NotFound or Conflict er…
RobertIndie Feb 5, 2025
6d6b4fe
Handle conflict exception for internalCreatePartitionedTopic
RobertIndie Feb 5, 2025
2b702dd
Use info level log for not found or conflict errors
RobertIndie Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Handle conflict exception for internalCreatePartitionedTopic
  • Loading branch information
@RobertIndie
RobertIndie committed Feb 5, 2025
commit 6d6b4fe3710a47de4f4df7c2bee2aa76914f120a
7 changes: 6 additions & 1 deletion pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,12 @@ && pulsar().getConfig().isCreateTopicToRemoteClusterForReplication()) {
asyncResponse.resume(Response.noContent().build());
})
.exceptionally(ex -> {
log.error("[{}] Failed to create partitioned topic {}", clientAppId(), topicName, ex);
if (AdminResource.isConflictException(ex)) {
log.warn("[{}] Failed to create partitioned topic {}: {}", clientAppId(), topicName,
ex.getMessage());
} else {
log.error("[{}] Failed to create partitioned topic {}", clientAppId(), topicName, ex);
}
resumeAsyncResponseExceptionally(asyncResponse, ex);
return null;
});
Expand Down
Loading