[fix][build] Use amazoncorretto:21-alpine3.20 JDK build for Alpine 3.20 #23898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested review from
merlimat,
Technoboy-,
nodece,
dao-jun,
nicoloboschi,
poorbarcode and
shibd
eolivelli
approved these changes
Jan 27, 2025
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the Pulsar Dockerfile, amazoncorretto:21-alpine is used as the JDK.
Since Alpine 3.21 has been released, it now contains a JDK built for Alpine 3.21, which might cause compatibility issues.
It's better to use the build that matches the Alpine version used in Pulsar.
Modifications
Use the ALPINE_VERSION argument so that amazoncorretto:21-alpine3.20 image is used, matching the ALPINE_VERSION of Pulsar image.
Documentation
docdoc-requireddoc-not-neededdoc-complete