[improve][fn] Set default tenant and namespace for ListFunctions cmd #23881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
approved these changes
Jan 23, 2025
@jiangpengcheng Just a small detail for future PRs: it's better to cleanup details from the PR description that don't apply to a specific PR. |
dao-jun
approved these changes
Jan 23, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23881 +/- ##
============================================
+ Coverage 73.57% 74.20% +0.63%
+ Complexity 32624 32231 -393
============================================
Files 1877 1853 -24
Lines 139502 143638 +4136
Branches 15299 16317 +1018
============================================
+ Hits 102638 106589 +3951
+ Misses 28908 28666 -242
- Partials 7956 8383 +427
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thx for remind, updated it |
nodece
approved these changes
Jan 24, 2025
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 27, 2025
…pache#23881) (cherry picked from commit 66d1bb0) (cherry picked from commit 1abbc3c)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 28, 2025
…pache#23881) (cherry picked from commit 66d1bb0) (cherry picked from commit 1abbc3c)
mukesh-ctds
added a commit
to datastax/pulsar
that referenced
this pull request
Feb 28, 2025
…ons cmd (apache#23881)" This reverts commit 5856a4e.
mukesh-ctds
added a commit
to datastax/pulsar
that referenced
this pull request
Feb 28, 2025
…stFunctions cmd (apache#23881)"" This reverts commit 14a7b58.
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 2, 2025
…pache#23881) (cherry picked from commit 66d1bb0) (cherry picked from commit 1abbc3c)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 2, 2025
…pache#23881) (cherry picked from commit 66d1bb0) (cherry picked from commit 1abbc3c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23880
Motivation
The list sources and sinks command will use default tenant and namespace when not specified, the list functions cmd should have the same bahaviour
Modifications
Verifying this change
Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
publicand namespacedefaultwill be usedDocumentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: jiangpengcheng#38