[improve][broker] Support values up to 2^32 in ConcurrentBitmapSortedLongPairSet #23878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested review from
Technoboy-,
codelipenghui,
nodece,
dao-jun,
poorbarcode,
shibd and
thetumbled
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23878 +/- ##
============================================
+ Coverage 73.57% 74.13% +0.56%
+ Complexity 32624 32187 -437
============================================
Files 1877 1853 -24
Lines 139502 143619 +4117
Branches 15299 16311 +1012
============================================
+ Hits 102638 106479 +3841
+ Misses 28908 28742 -166
- Partials 7956 8398 +442
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
approved these changes
Jan 23, 2025
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 31, 2025
…LongPairSet (apache#23878) (cherry picked from commit 0f9f661) (cherry picked from commit 2e0d575)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 3, 2025
…LongPairSet (apache#23878) (cherry picked from commit 0f9f661) (cherry picked from commit 2e0d575)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Feb 10, 2025
…LongPairSet (apache#23878) (cherry picked from commit 0f9f661)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ConcurrentBitmapSortedLongPairSet doesn't support long right-side values for the added pairs.
This PR mitigates the issue reported as #23877 by properly implementing the iterator so that values up to 2^32 can be supported.
In addition, this PR optimizes the iterator usable by using RoaringBitmap's PeekableIntIterator which is more performant than using Java's standard Iterator API since PeekableIntIterator uses primitive int values instead of using boxed Integer values.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete