[fix][broker] Fix incorrect blockedConsumerOnUnackedMsgs value when maxUnackedMessagesPerConsumer is 1

[summeriiii]

Fixes #22657

Motivation

This issue was introduced by #20990. After we call Consumer#addAndGetUnAckedMsgs to change the unackedMessages, we should check and may update blockedConsumerOnUnackedMsgs.

Modifications

• after change the unackedMessages, call updateBlockedConsumerOnUnackedMsgs to update blockedConsumerOnUnackedMsgs's value

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository:

[lhotari]

Good catch! I have one question in a comment.

[lhotari]

@summeriiii It looks like ZkSessionExpireTest.testTopicUnloadAfterSessionRebuild fails with this change. I haven't checked why, but that test has failed multiple times.

[summeriiii]

/pulsarbot run-failure-checks

[lhotari]

@summeriiii I was able to reproduce the failure by running the test in Docker with the scripts available at https://github.com/lhotari/pulsar-contributor-toolbox/blob/master/functions/pulsar-contributor-toolbox-functions.sh

git fetch origin pull/23796/merge
git checkout FETCH_HEAD
ptbx_run_test_in_docker -pl pulsar-broker test -Dtest=ZkSessionExpireTest

It's hard to see the reason why it would be caused by this PR.

Before the failure, I could see this output

2025-01-03T13:43:20,121 - WARN  - [Thread-161:BrokerService] - Namespace bundle for topic (persistent://public/default/tp-e6caf121-14dc-4443-9749-08435c188ca0) not served by this instance:localhost:55835. Please redo the lookup. Request is denied: namespace=public/default
2025-01-03T13:43:20,222 - WARN  - [Thread-162:BrokerService] - Namespace bundle for topic (persistent://public/default/tp-e6caf121-14dc-4443-9749-08435c188ca0) not served by this instance:localhost:55835. Please redo the lookup. Request is denied: namespace=public/default
2025-01-03T13:43:20,323 - WARN  - [Thread-163:BrokerService] - Namespace bundle for topic (persistent://public/default/tp-e6caf121-14dc-4443-9749-08435c188ca0) not served by this instance:localhost:55835. Please redo the lookup. Request is denied: namespace=public/default
2025-01-03T13:43:20,425 - WARN  - [Thread-164:BrokerService] - Namespace bundle for topic (persistent://public/default/tp-e6caf121-14dc-4443-9749-08435c188ca0) not served by this instance:localhost:55835. Please redo the lookup. Request is denied: namespace=public/default

[lhotari]

previous attempts https://github.com/apache/pulsar/actions/runs/12556467839 . Downloading logs to see if it's similar as what I see locally.

[lhotari]

Logs uploaded to https://gist.github.com/lhotari/b6d007083c043465f43e2b835cdc429e . I can see a similar errors in https://gist.githubusercontent.com/lhotari/b6d007083c043465f43e2b835cdc429e/raw/74948a7b872693105026732dc7ee243776fb9bc7/org.apache.pulsar.broker.service.ZkSessionExpireTest-output.txt

[lhotari]

The test has been flaky for a longer period of time: #23389

[lhotari]

The same ZkSessionExpireTest.testTopicUnloadAfterSessionRebuild test fails also in branch-4.0 builds. Let's continue addressing it in #23389 .

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.13%. Comparing base (bbc6224) to head (b97df18).
Report is 833 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23796      +/-   ##
============================================
+ Coverage     73.57%   74.13%   +0.56%     
+ Complexity    32624    31789     -835     
============================================
  Files          1877     1853      -24     
  Lines        139502   143470    +3968     
  Branches      15299    16291     +992     
============================================
+ Hits         102638   106362    +3724     
+ Misses        28908    28729     -179     
- Partials       7956     8379     +423     

Flag	Coverage Δ
inttests	26.65% <100.00%> (+2.07%)	⬆️
systests	23.21% <100.00%> (-1.12%)	⬇️
unittests	73.65% <100.00%> (+0.80%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ava/org/apache/pulsar/broker/service/Consumer.java	85.16% <100.00%> (-1.51%)	⬇️

... and 1023 files with indirect coverage changes