-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] [client] Fix memory leak when publishing encountered a corner case error #23738
Conversation
/pulsarbot rerun-failure-checks |
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ProducerCornerCaseTest.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ProducerCornerCaseTest.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ProducerCornerCaseTest.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ProducerCornerCaseTest.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23738 +/- ##
============================================
+ Coverage 73.57% 74.31% +0.73%
+ Complexity 32624 2374 -30250
============================================
Files 1877 1838 -39
Lines 139502 143053 +3551
Branches 15299 16232 +933
============================================
+ Hits 102638 106304 +3666
+ Misses 28908 28376 -532
- Partials 7956 8373 +417
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConnectionHandler.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ProducerCornerCaseTest.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ProducerCornerCaseTest.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ProducerCornerCaseTest.java
Outdated
Show resolved
Hide resolved
…ucerImpl.java Co-authored-by: Yunze Xu <xyzinfernity@163.com>
|
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ProducerMemoryLeakTest.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/TypedMessageBuilderImpl.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/TypedMessageBuilderImpl.java
Outdated
Show resolved
Hide resolved
…dMessageBuilderImpl.java
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ProducerMemoryLeakTest.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ProducerMemoryLeakTest.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ProducerMemoryLeakTest.java
Outdated
Show resolved
Hide resolved
@poorbarcode @BewareMyPower Please review #23761, that addresses a long time issue where the completable futures of pending messages weren't completed when close was called. It's also a case which could result into a resource leak situation. |
…ase error (apache#23738) Co-authored-by: Yunze Xu <xyzinfernity@163.com> (cherry picked from commit ab1b5c0) (cherry picked from commit 7915b66)
…ase error (apache#23738) Co-authored-by: Yunze Xu <xyzinfernity@163.com> (cherry picked from commit ab1b5c0) (cherry picked from commit 7915b66)
Motivation
Issue 1: memory leak if get errors when publishing
Conditions:
max message size
ProducerInterceptor. eligible
testSendQueueIsFull
,testSendMessageSizeExceeded
,testSendAfterClosedProducer
, andtestInterceptorError
Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: x