-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][fn] Improve closing of producers in Pulsar Functions ProducerCache invalidation #23734
Merged
lhotari
merged 4 commits into
apache:master
from
lhotari:lh-improve-functions-producercache-invalidation
Dec 17, 2024
Merged
[improve][fn] Improve closing of producers in Pulsar Functions ProducerCache invalidation #23734
lhotari
merged 4 commits into
apache:master
from
lhotari:lh-improve-functions-producercache-invalidation
Dec 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23734 +/- ##
============================================
+ Coverage 73.57% 74.42% +0.85%
- Complexity 32624 35111 +2487
============================================
Files 1877 1945 +68
Lines 139502 147518 +8016
Branches 15299 16282 +983
============================================
+ Hits 102638 109794 +7156
- Misses 28908 29252 +344
- Partials 7956 8472 +516
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lhotari
requested review from
Technoboy-,
nodece,
dao-jun,
merlimat and
david-streamlio
December 17, 2024 09:05
nodece
approved these changes
Dec 17, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 19, 2024
…erCache invalidation (apache#23734) (cherry picked from commit 9f046a5) (cherry picked from commit 6b9e9ac)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 21, 2024
…erCache invalidation (apache#23734) (cherry picked from commit 9f046a5) (cherry picked from commit 6b9e9ac)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 23, 2024
…erCache invalidation (apache#23734) (cherry picked from commit 9f046a5) (cherry picked from commit 6b9e9ac)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/function
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.9
release/3.3.4
release/4.0.2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PulsarClientException.AlreadyClosedException
is returned fromcloseAsync
.flushAsync
andcloseAsync
calls.Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete