Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Revert "[improve][client] Add log when can't add message to the container #23657

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

Technoboy-
Copy link
Contributor

@Technoboy- Technoboy- commented Nov 29, 2024

Motivation

Revert this patch #21924, as it has been fixed by #14139.
And this will involve many confused logs.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 29, 2024
@Technoboy- Technoboy- self-assigned this Nov 29, 2024
@Technoboy- Technoboy- requested review from lhotari and shibd November 29, 2024 01:59
@Technoboy- Technoboy- added this to the 4.1.0 milestone Nov 29, 2024
@Technoboy- Technoboy- closed this Nov 29, 2024
@Technoboy- Technoboy- reopened this Nov 29, 2024
@Technoboy- Technoboy- changed the title Revert "[improve][client] Add log when can't add message to the container [fix][broker] Revert "[improve][client] Add log when can't add message to the container Nov 29, 2024
@Technoboy- Technoboy- merged commit d1753ee into apache:master Nov 29, 2024
74 of 81 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.36%. Comparing base (bbc6224) to head (2f1a68c).
Report is 765 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23657      +/-   ##
============================================
+ Coverage     73.57%   74.36%   +0.78%     
+ Complexity    32624     2578   -30046     
============================================
  Files          1877     1944      +67     
  Lines        139502   147237    +7735     
  Branches      15299    16250     +951     
============================================
+ Hits         102638   109486    +6848     
- Misses        28908    29285     +377     
- Partials       7956     8466     +510     
Flag Coverage Δ
inttests 27.30% <ø> (+2.71%) ⬆️
systests 24.37% <ø> (+0.04%) ⬆️
unittests 73.73% <ø> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...va/org/apache/pulsar/client/impl/MessagesImpl.java 76.92% <ø> (ø)

... and 665 files with indirect coverage changes

lhotari pushed a commit that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants