-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][pip] PIP-390 Improve the reusability of Pulsar test code and best practice for unit and integration tests for Pulsar #23565
base: master
Are you sure you want to change the base?
Conversation
…e and best practices for unit and integration tests in Pulsar
@heesung-sn Please add the following content to your PR description and select a checkbox:
|
|
||
- Pulsar integration tests are located in the `tests` module, which run on [testcontainers](https://github.com/testcontainers). | ||
- Pulsar unit tests are located in each module under the test scope, with many tests running on mocked (in-memory) Pulsar clusters. | ||
- Currently, Pulsar tests run on the `testng` framework. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Currently, Pulsar tests run on the `testng` framework. | |
- Currently, Pulsar tests run on the [TestNG](https://testng.org/#_welcome_to_testng). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that directly providing the framework link may be clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So is Pulsar's testing going to switch to using JUnit 5 and remove testng?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So is Pulsar's testing going to switch to using JUnit 5 and remove testng?
@falser101 Perhaps eventually, but that will take a very long time. Instead of having the goal of converting from TestNG to JUnit5, I believe that it would be more valuable to first provide ways to create JUnit5 tests. There's not much value in doing a 1-to-1 mapping from TestNG to JUnit5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So is Pulsar's testing going to switch to using JUnit 5 and remove testng?
@falser101 Perhaps eventually, but that will take a very long time. Instead of having the goal of converting from TestNG to JUnit5, I believe that it would be more valuable to first provide ways to create JUnit5 tests. There's not much value in doing a 1-to-1 mapping from TestNG to JUnit5.
yes, maybe we can commit the first JUnit5 test case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized this pip is too much ambitious, and I am not sure it is practical any more. I am thinking of closing this PIP.
This is a PIP