[fix] [broker] PulsarRegistrationClient writableBookieInfo cache and readOnlyBookieInfo cache update fail causing broker to misjudge that the bookie is unavailable #23021
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…readOnlyBookieInfo cache update fail causing broker to misjudge that the bookie is unavailable.
|
@yyj8 Please add the following content to your PR description and select a checkbox: |
github-actions
bot
added
doc-not-needed
lhotari
added
the
release/blocker
lhotari
reviewed
May 14, 2025
| if ((info = writableBookieInfo.get(bookieId)) == null) { | ||
| log.warn("Bookie {} not found from all cache, now update writableBookieInfo cache " | ||
| + "and then try to get from writableBookieInfo cache.", bookieId); | ||
| readBookieInfoAsWritableBookie(bookieId); |
Member
There was a problem hiding this comment.
readBookieInfoAsWritableBookie returns a future so this doesn't seem to be the correct approach here. It would be necessary to use asynchronous callback chaining using CompletableFuture's .then* methods.
Member
|
It seems that #20642 attempted to fix some issues in this area. Useful for more context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23020
Main Issue: #xyz
PIP: #xyz
Motivation
The bookie process is running normally and there is corresponding bookie information in the metadata. Therefore, the broker's cache should also have corresponding bookie information. But the broker's cache does not have corresponding bookie information and causing broker to misjudge that the bookie is unavailable.
The broker prints the following exception information:
Modifications
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/bookkeeper/PulsarRegistrationClient.java#getBookieServiceInfo
yyj8@c52069f#diff-7a5305b98183695c3d8246b9e9ccafa68180d7f9e8df5534019d6bbcc59a90f6
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: