[fix][fn] Enable optimized Netty direct byte buffer support for Pulsar Function runtimes#22910
Merged
lhotari merged 3 commits intoJun 17, 2024
Conversation
lhotari
requested review from
cbornet,
dlg99,
eolivelli,
freeznet,
merlimat,
nicoloboschi and
nlu90
June 14, 2024 16:36
4 tasks
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 21, 2024
…r Function runtimes (apache#22910) (cherry picked from commit f3d4d5a) (cherry picked from commit 20de952)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 24, 2024
…r Function runtimes (apache#22910) (cherry picked from commit f3d4d5a) (cherry picked from commit 20de952)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 25, 2024
…r Function runtimes (apache#22910) (cherry picked from commit f3d4d5a) (cherry picked from commit 20de952)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 1, 2024
…r Function runtimes (apache#22910) (cherry picked from commit f3d4d5a) (cherry picked from commit 20de952)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…r Function runtimes (apache#22910)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22909
Motivation
Netty's optimized direct byte buffer support is needed for high performance. Currently these debug messages will get logged when Netty library gets initialized:
Another detail is that Pulsar uses com.scurrilous.circe.checksum.Crc32cIntChecksum class for checksum calculation. For optimized checksum calculation Pulsar attempts to load libcirce-checksum native library. When that isn't available, com.scurrilous.circe.checksum.Java9IntHash is used. That only works when "--add-opens java.base/java.util.zip=ALL-UNNAMED" is passed on the command line.
Modifications
Pass these parameters in the Java runtime command line:
remove
--add-opens java.base/sun.net=ALL-UNNAMEDadded in #16423 since it's no longer needed after #22329Documentation
docdoc-requireddoc-not-neededdoc-complete