Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] Upgrade to Oxia client 0.3.0 #22807

Merged
merged 1 commit into from
May 30, 2024

Conversation

zymap
Copy link
Member

@zymap zymap commented May 30, 2024

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@zymap zymap added doc-not-needed Your PR changes do not impact docs ready-to-test labels May 30, 2024
@zymap zymap added this to the 3.4.0 milestone May 30, 2024
@zymap zymap requested a review from merlimat May 30, 2024 07:56
@zymap zymap self-assigned this May 30, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.19%. Comparing base (bbc6224) to head (f23d2e5).
Report is 320 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22807      +/-   ##
============================================
- Coverage     73.57%   73.19%   -0.38%     
+ Complexity    32624     2511   -30113     
============================================
  Files          1877     1890      +13     
  Lines        139502   141644    +2142     
  Branches      15299    15541     +242     
============================================
+ Hits         102638   103678    +1040     
- Misses        28908    29960    +1052     
- Partials       7956     8006      +50     
Flag Coverage Δ
inttests 27.36% <ø> (+2.78%) ⬆️
systests 24.78% <ø> (+0.46%) ⬆️
unittests 72.20% <ø> (-0.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 363 files with indirect coverage changes

@merlimat merlimat merged commit 7ad157c into apache:master May 30, 2024
51 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants