Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve] [pip] PIP-356: Support Geo-Replication starts at earliest position #22791

Merged
merged 3 commits into from
May 30, 2024
Merged

[improve] [pip] PIP-356: Support Geo-Replication starts at earliest position #22791

merged 3 commits into from
May 30, 2024

Conversation

poorbarcode
Copy link
Contributor

@poorbarcode poorbarcode commented May 28, 2024 •
edited
Loading

Motivation

Modifications

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: x

@poorbarcode poorbarcode added this to the 3.4.0 milestone May 28, 2024
@poorbarcode poorbarcode self-assigned this May 28, 2024
@github-actions github-actions bot added PIP doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. labels May 28, 2024
BewareMyPower
BewareMyPower reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@BewareMyPower BewareMyPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we support this config on namespace level or even topic level? Otherwise, some topics might have large backlog that users don't want to replicate.

@poorbarcode
Copy link
Contributor Author

Should we support this config on namespace level or even topic level? Otherwise, some topics might have large backlog that users don't want to replicate.

Added

@poorbarcode poorbarcode requested a review from BewareMyPower May 29, 2024 07:04
@poorbarcode poorbarcode merged commit 43b20c3 into apache:master May 30, 2024
20 checks passed
@poorbarcode poorbarcode mentioned this pull request May 30, 2024
Merged
@poorbarcode
Copy link
Contributor Author

poorbarcode commented May 30, 2024 •
edited
Loading

Sorry, I merged it by mistake, I drafted another PR to revert the merging.

hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
@poorbarcode @hanmz
[improve] [pip] PIP-356: Support Geo-Replication starts at earliest p…
92a4243 
…osition (apache#22791)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Demogorgon314 Demogorgon314 Demogorgon314 approved these changes

@BewareMyPower BewareMyPower Awaiting requested review from BewareMyPower

Assignees

@poorbarcode poorbarcode

Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. PIP
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@poorbarcode @BewareMyPower @Demogorgon314