Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] [client] PIP-344 support feature flag supportsGetPartitionedMetadataWithoutAutoCreation #22773

Merged
merged 4 commits into from
Jun 6, 2024
Merged

[improve] [client] PIP-344 support feature flag supportsGetPartitionedMetadataWithoutAutoCreation #22773

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
27cc86b
[improve] [client] PIP-344 support feature flag supportsGetPartitione…
poorbarcode May 23, 2024
2136979
address comment
poorbarcode May 31, 2024
4fb8986
checkstyle
poorbarcode Jun 4, 2024
38cfadd
fix test
poorbarcode Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
checkstyle
  • Loading branch information
@poorbarcode
poorbarcode committed Jun 4, 2024
commit 4fb89861ff8264446cfc8cc2995e55144ab14e81
2 changes: 0 additions & 2 deletions pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ClientCnxTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.TimeUnit;
import org.apache.pulsar.PulsarVersion;
import org.apache.pulsar.broker.BrokerTestUtil;
import org.apache.pulsar.broker.auth.MockedPulsarServiceBaseTest;
Expand All @@ -36,7 +35,6 @@
import org.apache.pulsar.common.policies.data.ClusterData;
import org.apache.pulsar.common.policies.data.TenantInfoImpl;
import org.awaitility.Awaitility;
import org.mockito.Mockito;
import org.testng.Assert;
import org.testng.annotations.AfterClass;
import org.testng.annotations.BeforeClass;
Expand Down Expand Up @@ -162,7 +160,7 @@
clientWitBinaryLookup.getPartitionsForTopic(topic, false).join();
Assert.fail("Expected an error that the broker version is too old.");
} catch (Exception ex) {
Assert.assertTrue(ex.getMessage().contains("version is too old to support getting partitions"));

Check failure on line 163 in pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ClientCnxTest.java

View workflow job for this annotation

GitHub Actions / CI - Unit - Brokers - Client Impl

ClientCnxTest.testSupportsGetPartitionedMetadataWithoutAutoCreation 

expected [true] but found [false]
}

// cleanup.
Expand Down
Loading