Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][build] Add curl command for pulsar image #22732

Merged
merged 1 commit into from
May 17, 2024

Conversation

coderzc
Copy link
Member

@coderzc coderzc commented May 17, 2024

Motivation

Many components need to rely on curl command when testing, so we should add curl command to the pulsar image.
More context:
https://lists.apache.org/thread/mkxsz2tjbmlmqpsbh77sdll9b36o8pgv

Modifications

Add curl command for pulsar image

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 17, 2024
@coderzc coderzc changed the title [fix][build] Install curl for pulsar image [fix][build] Add curl command for pulsar image May 17, 2024
@coderzc coderzc self-assigned this May 17, 2024
@coderzc coderzc added release/blocker Indicate the PR or issue that should block the release until it gets resolved release/3.3.0 area/test ready-to-test and removed area/test labels May 17, 2024
@coderzc coderzc closed this May 17, 2024
@coderzc coderzc reopened this May 17, 2024
Copy link
Member

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dao-jun dao-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.19%. Comparing base (bbc6224) to head (9b2f4d6).
Report is 279 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22732      +/-   ##
============================================
- Coverage     73.57%   73.19%   -0.39%     
- Complexity    32624    32864     +240     
============================================
  Files          1877     1889      +12     
  Lines        139502   141399    +1897     
  Branches      15299    15517     +218     
============================================
+ Hits         102638   103491     +853     
- Misses        28908    29925    +1017     
- Partials       7956     7983      +27     
Flag Coverage Δ
inttests 27.19% <ø> (+2.60%) ⬆️
systests 24.74% <ø> (+0.41%) ⬆️
unittests 72.20% <ø> (-0.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 355 files with indirect coverage changes

@dao-jun dao-jun merged commit edde408 into apache:master May 17, 2024
72 of 80 checks passed
@dao-jun dao-jun removed the release/blocker Indicate the PR or issue that should block the release until it gets resolved label May 17, 2024
coderzc added a commit that referenced this pull request May 17, 2024
@lhotari lhotari added this to the 4.0.0 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants