-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][build] Add curl command for pulsar image #22732
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22732 +/- ##
============================================
- Coverage 73.57% 73.19% -0.39%
- Complexity 32624 32864 +240
============================================
Files 1877 1889 +12
Lines 139502 141399 +1897
Branches 15299 15517 +218
============================================
+ Hits 102638 103491 +853
- Misses 28908 29925 +1017
- Partials 7956 7983 +27
Flags with carried forward coverage won't be shown. Click here to find out more. |
(cherry picked from commit edde408)
Motivation
Many components need to rely on curl command when testing, so we should add curl command to the pulsar image.
More context:
https://lists.apache.org/thread/mkxsz2tjbmlmqpsbh77sdll9b36o8pgv
Modifications
Add curl command for pulsar image
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: