[improve][broker] Taking message deduplication snapshot when closing topic #22498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…topic Taking message deduplication snapshot when closing the topic to avoid reply large logs when the topic loads again.
mattisonchao
added
area/broker
category/reliability
Technoboy-
approved these changes
Apr 14, 2024
dao-jun
approved these changes
Apr 15, 2024
|
@mattisonchao Please fix the ci check failures |
|
sorry, this PR still need some changes. @dao-jun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current implementation of message deduplication snapshot-taking may leave a very huge lag when traffic is high. if load balancer or someone tries to unload/load this topic the loading process may taking very long time.
Modifications
snapshotmethod return a future.Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-complete