[improve][test] Reduce AdvertisedListenersMultiBrokerLeaderElectionTest flakiness #22258
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st flakiness - shutdown executors immediately - ensure that all waiting threads terminate
|
I'm not sure this fix could resolve the flakiness |
I'm not either. It is to reduce issues and this change isn't harmful. |
asafm
approved these changes
Mar 13, 2024
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
AdvertisedListenersMultiBrokerLeaderElectionTest is flaky. This change is to reduce issues and this change isn't harmful.
The thread leak detector reported leaked threads. The way this could help is that when the test fails, cleanup would happen properly and the test retry could pass with better chance.
There's no guarantee that this would eliminate the flakiness problem, but it's useful for cleanups related to test retries.
Modifications
.shutdownNow()instead of.shutdown().forceTermination()on the phaser instance (this could also be taken care by.shutdownNow().Documentation
docdoc-requireddoc-not-neededdoc-complete