Skip to content

[improve][test] Reduce logging overhead in tests #22251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 12, 2024
Merged

[improve][test] Reduce logging overhead in tests #22251

merged 4 commits into from
Mar 12, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Mar 12, 2024 •
edited
Loading

Motivation

Modifications

  • don't log the location where the log was added since this causes a high overhead

Additional context

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari
[improve][test] Reduce logging overhead in tests
e0d8c9f 
- don't log the location where the log was added since this causes a high overhead
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 12, 2024
@lhotari lhotari mentioned this pull request Mar 12, 2024
Closed
2 tasks
@lhotari lhotari requested a review from Technoboy- March 12, 2024 12:29
@lhotari lhotari marked this pull request as draft March 12, 2024 12:56
@lhotari lhotari marked this pull request as ready for review March 12, 2024 13:01
@asafm
Copy link
Contributor

asafm commented Mar 12, 2024

Wow. I didn't know that!
Is this layout also used in the default log4j.xml we ship?

@lhotari
Copy link
Member Author

lhotari commented Mar 12, 2024

Is this layout also used in the default log4j.xml we ship?

@asafm no, it was only used in tests.

@lhotari lhotari merged commit 4eb3034 into apache:master Mar 12, 2024
@lhotari lhotari mentioned this pull request Mar 19, 2024
Closed
4 tasks
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
@lhotari @hanmz
[improve][test] Reduce logging overhead in tests (apache#22251)
ef5447c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asafm asafm asafm approved these changes

@Technoboy- Technoboy- Technoboy- approved these changes

@liangyepianzhou liangyepianzhou liangyepianzhou approved these changes

Assignees

@lhotari lhotari

Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lhotari @asafm @Technoboy- @liangyepianzhou