[fix][sec] implicit narrowing conversion in compound assignment

[liangyepianzhou]

Fix https://github.com/apache/pulsar/security/code-scanning/20, https://github.com/apache/pulsar/security/code-scanning/7

Motivation

The implicit casting of source type double/long to narrower destination type int can result in information loss and numeric errors such as overflows.

Modifications

Ensure that the type of the left-hand side of the compound assignment statement is at least as wide as the type of the right-hand side.

Verifying this change

• Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

• Added integration tests for end-to-end deployment with large payloads (10MB)
• Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository: