Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][fix][broker] Fix topic lookup with Admin API when using advertised listeners #22062

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[WIP][fix][broker] Fix topic lookup with Admin API when using advertised listeners #22062

wants to merge 1 commit into from

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Feb 16, 2024 •
edited
Loading

This PR is WIP

Motivation

PIP-61 and PIP-95 isn't fully implemented in the Pulsar code base.
For example, topic lookup with Admin API is broken when using advertised listeners.

Modifications

  • cover gaps in redirects to handle advertised listeners
  • allow having both Pulsar binary protocol (pulsar & pulsar+ssl) and web api (http & https) with the same listener name by removing the unnecessary restriction of max 2 endpoints for a listener name

Additional context

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari
[fix][broker] Fix topic lookup with Admin API when using advertised l…
b43f9aa 
…isteners

- also allow having both Pulsar binary protocol (pulsar & pulsar+ssl) and web api (http & https)
  with the same listener name by removing the unnecessary restriction
@lhotari lhotari added type/bug The PR fixed a bug or issue reported a bug area/broker labels Feb 16, 2024
@lhotari lhotari added this to the 3.3.0 milestone Feb 16, 2024
@lhotari lhotari self-assigned this Feb 16, 2024
@lhotari lhotari changed the title [fix][broker] Fix topic lookup with Admin API when using advertised listeners [WIP][fix][broker] Fix topic lookup with Admin API when using advertised listeners Feb 16, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 16, 2024
@coderzc coderzc modified the milestones: 3.3.0, 3.4.0 May 8, 2024
@lhotari lhotari modified the milestones: 4.0.0, 4.1.0 Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lhotari lhotari

Labels
area/broker doc-not-needed Your PR changes do not impact docs type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lhotari @coderzc